♻️ Fix code smells (#230)

src/clients/discord/discord.message.service.ts

@@ -15,8 +15,8 @@ export class DiscordMessageService {
     description?: string;
   }): APIEmbed {
     return this.buildMessage({
-      title: title,
+      title,
-      description: description,
+      description,
       mixin(embedBuilder) {
         return embedBuilder
           .setAuthor({

src/clients/jellyfin/jellyfin.search.service.ts

@@ -44,9 +44,9 @@ export class JellyfinSearchService {
 
     try {
       const { data, status } = await searchApi.get({
-        searchTerm: searchTerm,
+        searchTerm,
-        includeItemTypes: includeItemTypes,
+        includeItemTypes,
-        limit: limit,
+        limit,
       });
 
       if (status !== 200) {
@@ -138,7 +138,7 @@ export class JellyfinSearchService {
     const { data } = await searchApi.getItems({
       ids: [id],
       userId: this.jellyfinService.getUserId(),
-      includeItemTypes: includeItemTypes,
+      includeItemTypes,
     });
 
     if (!data.Items || data.Items.length !== 1) {
@@ -157,9 +157,9 @@ export class JellyfinSearchService {
 
     const searchApi = getItemsApi(api);
     const { data } = await searchApi.getItems({
-      ids: ids,
+      ids,
       userId: this.jellyfinService.getUserId(),
-      includeItemTypes: includeItemTypes,
+      includeItemTypes,
     });
 
     if (!data.Items || data.Items.length !== 1) {
@@ -184,7 +184,7 @@ export class JellyfinSearchService {
       const axiosReponse = await remoteImageApi.getRemoteImages({
         itemId: id,
         includeAllLanguages: true,
-        limit: limit,
+        limit,
       });
 
       if (axiosReponse.status !== 200) {
@@ -219,7 +219,7 @@ export class JellyfinSearchService {
     try {
       const response = await searchApi.getItems({
         includeItemTypes: [BaseItemKind.Audio],
-        limit: limit,
+        limit,
         sortBy: ['random'],
         userId: this.jellyfinService.getUserId(),
         recursive: true,

src/commands/disconnect.command.ts

@@ -12,7 +12,7 @@ import { defaultMemberPermissions } from 'src/utils/environment';
 @Command({
   name: 'disconnect',
   description: 'Join your current voice channel',
-  defaultMemberPermissions: defaultMemberPermissions,
+  defaultMemberPermissions,
 })
 export class DisconnectCommand {
   constructor(

src/commands/help.command.ts

@@ -11,7 +11,7 @@ import { defaultMemberPermissions } from 'src/utils/environment';
 @Command({
   name: 'help',
   description: 'Get help if you're having problems with this bot',
-  defaultMemberPermissions: defaultMemberPermissions,
+  defaultMemberPermissions,
 })
 export class HelpCommand {
   constructor(private readonly discordMessageService: DiscordMessageService) {}

src/commands/next.command.ts

@@ -11,7 +11,7 @@ import { defaultMemberPermissions } from 'src/utils/environment';
 @Command({
   name: 'next',
   description: 'Go to the next track in the playlist',
-  defaultMemberPermissions: defaultMemberPermissions,
+  defaultMemberPermissions,
 })
 @Injectable()
 export class SkipTrackCommand {

src/commands/pause.command.ts

@@ -12,7 +12,7 @@ import { defaultMemberPermissions } from 'src/utils/environment';
 @Command({
   name: 'pause',
   description: 'Pause or resume the playback of the current track',
-  defaultMemberPermissions: defaultMemberPermissions,
+  defaultMemberPermissions,
 })
 export class PausePlaybackCommand {
   constructor(

src/commands/play/play.comands.ts

@@ -34,7 +34,7 @@ import { PlayCommandParams, SearchType } from './play.params.ts';
 @Command({
   name: 'play',
   description: 'Search for an item on your Jellyfin instance',
-  defaultMemberPermissions: defaultMemberPermissions,
+  defaultMemberPermissions,
 })
 export class PlayItemCommand {
   private readonly logger: Logger = new Logger(PlayItemCommand.name);

src/commands/playlist/playlist.command.ts

@@ -42,7 +42,7 @@ import { defaultMemberPermissions } from 'src/utils/environment';
 @Command({
   name: 'playlist',
   description: 'Print the current track information',
-  defaultMemberPermissions: defaultMemberPermissions,
+  defaultMemberPermissions,
 })
 @UseInterceptors(CollectorInterceptor)
 @UseCollectors(PlaylistInteractionCollector)

src/commands/previous.command.ts

@@ -12,7 +12,7 @@ import { defaultMemberPermissions } from 'src/utils/environment';
 @Command({
   name: 'previous',
   description: 'Go to the previous track',
-  defaultMemberPermissions: defaultMemberPermissions,
+  defaultMemberPermissions,
 })
 export class PreviousTrackCommand {
   constructor(

src/commands/random/random.command.ts

@@ -17,7 +17,7 @@ import { defaultMemberPermissions } from 'src/utils/environment';
 @Command({
   name: 'random',
   description: 'Enqueues a random selection of tracks to your playlist',
-  defaultMemberPermissions: defaultMemberPermissions,
+  defaultMemberPermissions,
 })
 @Injectable()
 export class EnqueueRandomItemsCommand {

src/commands/stop.command.ts

@@ -12,7 +12,7 @@ import { defaultMemberPermissions } from 'src/utils/environment';
 @Command({
   name: 'stop',
   description: 'Stop playback entirely and clear the current playlist',
-  defaultMemberPermissions: defaultMemberPermissions,
+  defaultMemberPermissions,
 })
 @Injectable()
 export class StopPlaybackCommand {
@@ -41,8 +41,8 @@ export class StopPlaybackCommand {
         this.discordMessageService[
           hasActiveTrack ? 'buildMessage' : 'buildErrorMessage'
         ]({
-          title: title,
+          title,
-          description: description,
+          description,
         }),
       ],
     });

src/commands/summon.command.ts

@@ -12,7 +12,7 @@ import { defaultMemberPermissions } from 'src/utils/environment';
 @Command({
   name: 'summon',
   description: 'Join your current voice channel',
-  defaultMemberPermissions: defaultMemberPermissions,
+  defaultMemberPermissions,
 })
 export class SummonCommand {
   private readonly logger = new Logger(SummonCommand.name);

src/commands/volume/volume.command.ts

@@ -16,7 +16,7 @@ import { defaultMemberPermissions } from 'src/utils/environment';
 @Command({
   name: 'volume',
   description: 'Change the volume',
-  defaultMemberPermissions: defaultMemberPermissions,
+  defaultMemberPermissions,
 })
 export class VolumeCommand {
   private readonly logger = new Logger(VolumeCommand.name);

src/utils/timeUtils.ts

@@ -10,7 +10,7 @@ export const formatMillisecondsAsHumanReadable = (
       end: 0,
     }),
     {
-      format: format,
+      format,
     },
   );
   return duration;